You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The p-as-heading check can return undefined but does not have an incomplete message. Not having a message for a check state is bad. Investigate if we can somehow write a test to ensure that for the unit tests that there is a 1:1 message for each state.
One idea we can look at is to use the testutil helper function getCheckEvaluate to look at the returned state of the check. Using that we can write an assert that checks that each return state has a corresponding message. This will work for generic pass, fail, and incomplete messages but won't help much for messages determined by messageKey. For that we can use the checkContext mock function in testutils to assert that if messageKey is used there is a corresponding message.
The text was updated successfully, but these errors were encountered:
The
p-as-heading
check can return undefined but does not have an incomplete message. Not having a message for a check state is bad. Investigate if we can somehow write a test to ensure that for the unit tests that there is a 1:1 message for each state.One idea we can look at is to use the testutil helper function
getCheckEvaluate
to look at the returned state of the check. Using that we can write an assert that checks that each return state has a corresponding message. This will work for genericpass
,fail
, andincomplete
messages but won't help much for messages determined bymessageKey
. For that we can use thecheckContext
mock function in testutils to assert that ifmessageKey
is used there is a corresponding message.The text was updated successfully, but these errors were encountered: