fix: Make empty role=lisbox elements as incomplete #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
reviewed
May 28, 2018
lib/checks/aria/required-children.js
Outdated
| @@ -86,4 +87,10 @@ var missing = missingRequiredChildren(node, childRoles, all, role); | |||
| if (!missing) { return true; } | |||
|
|
|||
| this.data(missing); | |||
| return false; | |||
|
|
|||
| console.log(role, reviewEmpty.includes(role), missing); | |||
There was a problem hiding this comment.
Nope. Why did you approve?
jeeyyy
approved these changes
May 28, 2018
WilcoFiers
force-pushed
the
listbox-children
branch
from
86fa6b1 to
d4ea781
Compare
|
@WilcoFiers shouldn't we just pass these, rather than making them a review item? An empty list is a valid list after all. |
|
@dylanb ARIA says that options are required owned elements. It seems to me most of the time that there are no options, someone f'ed up. I think any time something disagrees with ARIA, it probably deserves a review. |
|
I think it is actually an oversight on the part of ARIA. Even their own examples have this issue http://w3c.github.io/aria-practices/examples/listbox/listbox-rearrangeable.html |
BrendanMcK
reviewed
Dec 12, 2018
| @@ -1,11 +1,15 @@ | |||
| { | |||
| "id": "aria-required-children", | |||
| "evaluate": "required-children.js", | |||
| "options": { | |||
| "reviewEmpty": ["listbox"] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Description of the changes
Does this PR introduce a breaking change?
Other information