feat: add imagePullSecrets and imagePullPolicy configuration for shellpod #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementLachaussee
changed the title
derailed
requested changes
Nov 21, 2023
There was a problem hiding this comment.
@ClementLachaussee Great addition! Thank you for this PR Clement!
Just a few small picks...
derailed
added
enhancement
|
Thanks @derailed for the reviews. I think this looks better now. |
derailed
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
@ClementLachaussee Very cool! Thank you for these updates Clement!!
Merged
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
…lpod (derailed#2301) * feat: add imagePullSecrets and imagePullPolicy in shell_pod for internal registry use cases * docs: add imagePullPolicy and imagePullSecrets configuration example * docs: remove comments * docs: use same wording * docs: remove useless phrase * fix: truncated comment * fix: use correct type, remove useless if * add: ImagePullPolicy on container variable --------- Co-authored-by: clementlachaussee <[email protected]>
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
…lpod (derailed#2301) * feat: add imagePullSecrets and imagePullPolicy in shell_pod for internal registry use cases * docs: add imagePullPolicy and imagePullSecrets configuration example * docs: remove comments * docs: use same wording * docs: remove useless phrase * fix: truncated comment * fix: use correct type, remove useless if * add: ImagePullPolicy on container variable --------- Co-authored-by: clementlachaussee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2300
This is to be able to use internal registries and set imagePullPolicy
This doesn't change the default configuration of k9s, but enables the use of shellpod when public registries are off-limit due to company policies.