Added ln check for snap #2357
Merged
Added ln check for snap #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realised that if you manually created (or already had) a ln it would cause the build to fail. So added in a check to see if it exists. Moved commands out of prime-override as it didnt really add anything and made it harder to read
The snap package was being built with 0.29.1 but is presenting as 0.27 still (locally and in ubuntu snap store)
Merged
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
* Added ln check for snap Realised that if you manually created (or already had) a ln it would cause the build to fail. So added in a check to see if it exists. Moved commands out of prime-override as it didnt really add anything and made it harder to read * Version no. update to 0.29.1 The snap package was being built with 0.29.1 but is presenting as 0.27 still (locally and in ubuntu snap store)
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
* Added ln check for snap Realised that if you manually created (or already had) a ln it would cause the build to fail. So added in a check to see if it exists. Moved commands out of prime-override as it didnt really add anything and made it harder to read * Version no. update to 0.29.1 The snap package was being built with 0.29.1 but is presenting as 0.27 still (locally and in ubuntu snap store)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realised that if you manually created (or already had) a ln it would cause the build to fail. So added in a check to see if it exists.
Moved commands out of prime-override as it didn't really add anything and made it harder to read
Additional small changes