Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path of the results file changed from v0.11 to v0.20 #316

Closed
johnqa opened this issue Jun 26, 2024 · 1 comment
Closed

Path of the results file changed from v0.11 to v0.20 #316

johnqa opened this issue Jun 26, 2024 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@johnqa
Copy link

johnqa commented Jun 26, 2024




Describe the bug
I am running popeye with docker and I noticed that the same command using image v0.11.3 and v0.20.0 put the report file in different locations:
/tmp/popeye/report_file.html for v0.11.3
and
/tmp/popeye/<cluster_name or user>/<cluster_name or user>/my_report.txt for v0.20.0 and after (including v.0.21.3).

Setting a POPEYE_REPORT_DIR only replaces /tmp/popeye with the path from env variable.

To Reproduce
Steps to reproduce the behavior:

  1. Run docker command with both versions:
docker run --rm -v $(pwd)/config:/home/nonroot/.kube/config -v /tmp:/tmp \
  derailed/popeye:v0.21.3  -n bar --save --output-file my_report.txt
--result--
/tmp/popeye/<cluster_name or user>/<cluster_name or user>/my_report.txt
docker run --rm -v $(pwd)/config:/home/nonroot/.kube/config -v /tmp:/tmp \
  derailed/popeye:v0.11.3  -n bar --save --output-file my_report.txt
--result--
/tmp/popeye/my_report.txt

Expected behavior
Is there a way to have a fixed path that I can set with POPEYE_REPORT_DIR and nothing extra to be added?

@derailed
Copy link
Owner

@johnqa Thank you for this issue!

You are correct. Since users may target different clusters and hence we want to dump the reports in cluster specific location.
That said we can relax this a bit and assume if the user overrides the default report location then this should be the final report resting place with no alterations.
I'll update the code to change the behavior ie if you set POPEYE_REPORT_DIR env var then the reports will land there.
Watch for this in the next drop.

@derailed derailed added enhancement New feature or request question Further information is requested labels Sep 14, 2024
@derailed derailed mentioned this issue Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants