Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize what is considered a warning or error by the SpinachYAML file #43

Closed
elvisFabian opened this issue Jul 11, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@elvisFabian
Copy link

elvisFabian commented Jul 11, 2019

Is your feature request related to a problem? Please describe.
In my scenario I would like resource request/presence limits to be an error.
In the current scenario it is a warning.

Describe the solution you'd like
Parametrize what is considered a warning or error by the SpinachYAML file.
This could be used for any Sanitizers

@derailed derailed added the enhancement New feature or request label Jul 13, 2019
@derailed
Copy link
Owner

@elvisFabian Excellent!! Thank you for your input. I agree with this concept as cluster owners should be able to choose the sanitizers severity levels for their clusters. I have been thinking about using a sanitizer issue classification. Much like HTTP error codes. I think we could then use your concept to further classify an issue as a info/warning/error/etc..
For instance a Popeye-404: Warning: Missing container resources could then be overridden in a config file as an error on your cluster. What do you guys think?

@derailed
Copy link
Owner

derailed commented Aug 3, 2019

@elvisFabian Fixed v0.4.1! Please see v0.4.0 release notes and how you can override the severity in your spinach.yml config file. Thank you!

@derailed derailed closed this as completed Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants