Jacksonville 3 Letter Abbreviation

[ToddAtWSU]

So I have a script that uses a team's full name (i.e. Jacksonville) and grabs it's 3 letter abbreviation. For Jacksonville, this returns JAC, but the games use JAX which means I can never find Jacksonville in a game. Here is some relevant code showing my issue.

nflTeams = nflgame.teams
#teams is a list of full names I read in from a file earlier in the code, names include "Jacksonville" and "New England"
for team in teams:
    # Loop through all NFL teams i.e. all 32 teams
    for nflTeam in nflTeams:
        # Check if this NFL team is our fantasy team
        if team == nflTeam[1]:
            # We have found our team, now loop through all
            # games since games use team abbreviations
            for game in week:
            # Here nflTeam[0] will have "JAC" and game.away or game.home will have "JAX"
                if nflTeam[0] == game.away:
                # Some code here...
                elif nflTeam[0] == game.home:
                # More code here...

So should both of these use JAX or JAC and not one and the other?

[ochawkeye]

That code doesn't run...how is it supposed to show your issue? :P

So should both of these use JAX or JAC and not one and the other?

This is another case where we can't control what the NFL gives us. Case in point:

import nflgame

for year in range(2009, 2019):
    for abbreviation in ['JAC', 'JAX']:

        try:
            games = nflgame.games(year, week=1, kind='REG', home=abbreviation, away=abbreviation)
            for game in games:
                print year, game
        except TypeError:
            continue

2009 JAC (12) at IND (14)
2010 DEN (17) at JAC (24)
2011 TEN (14) at JAC (16)
2012 JAC (23) at MIN (26)
2013 KC (28) at JAC (2)
2014 JAC (17) at PHI (34)
2015 CAR (20) at JAC (9)
2016 GB (27) at JAC (23)
2017 JAX (29) at HOU (7)
2018 JAX (20) at NYG (15)

I do notice that at some pont I must have changed my ..\nflgame\__init__.py to the following:

teams = [
...
    ['JAX', 'Jacksonville', 'Jaguars', 'Jacksonville Jaguars', 'JAC'],
...

but I don't think that should matter. since using the nflgame.standard_team() function can normalize our team name to whatever nflgame might be expecting to see for the abbreviation.

nflTeams = nflgame.teams
#teams is a list of full names I read in from a file earlier in the code, names include "Jacksonville" and "New England"
for team in teams:
    # Loop through all NFL teams i.e. all 32 teams
    for nflTeam in nflTeams:
        # Check if this NFL team is our fantasy team
        if team == nflTeam[1]:
            # We have found our team, now loop through all
            # games since games use team abbreviations
            for game in week:
            # Here nflTeam[0] will have "JAC" and game.away or game.home will have "JAX"
                if nflTeam[0] == nflgame.standard_team(game.away):
                # Some code here...
                elif nflTeam[0] == nflgame.standard_team(game.home):
                # More code here...

[reddigari]

I'm encountering a similar problem updating a (new) nfldb database with this fork of nflgame. Running nfldb-update raises this error:

psycopg2.IntegrityError: insert or update on table "play" violates foreign key constraint "play_pos_team_fkey"
DETAIL:  Key (pos_team)=(JAX) is not present in table "team".

I'd rather not fidget with the nfldb code; is there a quick-fix I can do on the nflgame side to re-write the JSON data to play nicely with the database?

[derek-adair]

Ya... this threw me for a loop when i first got into this project. I think it is a valid point to have something check all abbreviations and return a normalized and consistent format.

As for how this affects nfldb really not sure how to advise you there.

[derek-adair]

Closing as a known issue with a acceptable workaround.

Workaround: handle it manually

for year in range(2009, 2019):
    for abbreviation in ['JAC', 'JAX']:

        try:
            games = nflgame.games(year, week=1, kind='REG', home=abbreviation, away=abbreviation)
            for game in games:
                print year, game
        except TypeError:
            continue

This is very likely to change and/or go away when we start work on #46.