Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH5082] Suisin/trah5082/change traders hub button url based on ff #17916

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Change redirection to hub.deriv.com/staging-hub.deriv.com from TH wallets page

Screenshots:

Screen.Recording.2024-12-31.at.1.33.30.PM.mov

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 10, 2025 1:19pm

@coveralls
Copy link

coveralls commented Dec 31, 2024

Pull Request Test Coverage Report for Build 12653976123

Details

  • 31 of 88 (35.23%) changed or added relevant lines in 16 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-5.0%) to 53.726%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Containers/ResetPasswordModal/reset-password-modal.tsx 2 3 66.67%
packages/wallets/src/AppContent.tsx 0 1 0.0%
packages/wallets/src/components/ModalProvider/ModalProvider.tsx 4 5 80.0%
packages/wallets/src/routes/Router.tsx 0 1 0.0%
packages/wallets/src/routes/WalletsListingRoute/WalletsListingRoute.tsx 2 3 66.67%
packages/core/src/App/Containers/AccountSwitcherWallet/account-switcher-wallet-mobile.tsx 5 7 71.43%
packages/core/src/App/Containers/AccountSwitcherWallet/account-switcher-wallet.tsx 5 7 71.43%
packages/core/src/App/Containers/LinkExpiredModal/link-expired-modal.tsx 4 6 66.67%
packages/core/src/App/Components/Layout/Header/platform-dropdown.jsx 4 7 57.14%
packages/core/src/Stores/client-store.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
packages/core/src/App/Containers/Redirect/redirect.jsx 1 0.72%
packages/trader/src/AppV2/Components/TradeParameters/Duration/day.tsx 1 58.82%
packages/core/src/Stores/ui-store.js 2 0.0%
Totals Coverage Status
Change from base Build 12650710749: -5.0%
Covered Lines: 33116
Relevant Lines: 57426

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 31, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17916](https://github.com/deriv-com/deriv-app/pull/17916)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-trah5082changetra-e2c858.binary.sx?qa_server=red.derivws.com&app_id=24061
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-trah5082changetra-e2c858.binary.sx
- **App ID**: `24061`

Copy link
Contributor

github-actions bot commented Dec 31, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-trah5082changetra-e2c858.binary.sx/

shahzaib-deriv
shahzaib-deriv previously approved these changes Dec 31, 2024
heorhi-deriv
heorhi-deriv previously approved these changes Dec 31, 2024
habib-deriv
habib-deriv previously approved these changes Jan 10, 2025
@habib-deriv habib-deriv merged commit 8664cb5 into deriv-com:master Jan 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants