-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRAH5082] Suisin/trah5082/change traders hub button url based on ff #17916
Merged
habib-deriv
merged 18 commits into
deriv-com:master
from
suisin-deriv:suisin/TRAH5082/change_traders_hub_button_url_based_on_FF
Jan 10, 2025
Merged
[TRAH5082] Suisin/trah5082/change traders hub button url based on ff #17916
habib-deriv
merged 18 commits into
deriv-com:master
from
suisin-deriv:suisin/TRAH5082/change_traders_hub_button_url_based_on_FF
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
sandeep-deriv,
yashim-deriv,
heorhi-deriv and
jim-deriv
as code owners
December 31, 2024 05:34
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
suisin-deriv
had a problem deploying
to
Preview
December 31, 2024 05:34 — with
GitHub Actions
Failure
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-trah5082changetra-e2c858.binary.sx/ |
shahzaib-deriv
previously approved these changes
Dec 31, 2024
packages/core/src/App/Containers/AccountSwitcherWallet/account-switcher-wallet.tsx
Outdated
Show resolved
Hide resolved
lubega-deriv
approved these changes
Dec 31, 2024
heorhi-deriv
previously approved these changes
Dec 31, 2024
amina-deriv
reviewed
Dec 31, 2024
packages/core/src/App/Containers/RootComponent/root-component.jsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Dec 31, 2024
suisin-deriv
force-pushed
the
suisin/TRAH5082/change_traders_hub_button_url_based_on_FF
branch
from
January 7, 2025 15:12
891cef2
to
028922c
Compare
habib-deriv
previously approved these changes
Jan 10, 2025
suisin-deriv
force-pushed
the
suisin/TRAH5082/change_traders_hub_button_url_based_on_FF
branch
from
January 10, 2025 12:55
204b61e
to
57bb892
Compare
habib-deriv
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Change redirection to hub.deriv.com/staging-hub.deriv.com from TH wallets page
Screenshots:
Screen.Recording.2024-12-31.at.1.33.30.PM.mov