Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: persist debs, rpms #4124

Merged
merged 1 commit into from
May 13, 2022
Merged

ci: persist debs, rpms #4124

merged 1 commit into from
May 13, 2022

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented May 12, 2022

Description

Needed, particularly in EE, to publish these artifacts to the correct places.

Test Plan

  • run with the storing code in the 'local' package target and make sure debs are retrievable via circle API

Commentary (optional)

Checklist

  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 12, 2022
@netlify
Copy link

netlify bot commented May 12, 2022

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit e3448f8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/627d67775f48960009cdba22

@stoksc stoksc force-pushed the persist-debs-rpms branch from 5d64cb4 to acbd278 Compare May 12, 2022 19:40
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #4124 (e3448f8) into master (2c7564d) will increase coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4124      +/-   ##
==========================================
+ Coverage   39.72%   40.20%   +0.47%     
==========================================
  Files         756      756              
  Lines       57472    57472              
  Branches     2804     2804              
==========================================
+ Hits        22833    23104     +271     
+ Misses      34295    34022     -273     
- Partials      344      346       +2     
Flag Coverage Δ
backend 22.40% <ø> (-0.04%) ⬇️
harness 65.93% <ø> (+1.23%) ⬆️
web 25.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ernal/resourcemanagers/kubernetes/request_queue.go 80.41% <0.00%> (-6.19%) ⬇️
master/internal/rw_coordinator.go 65.68% <0.00%> (-2.95%) ⬇️
harness/determined/common/util.py 74.19% <0.00%> (+3.22%) ⬆️
harness/tests/storage/test_s3.py 94.20% <0.00%> (+23.18%) ⬆️
harness/tests/conftest.py 100.00% <0.00%> (+25.00%) ⬆️
harness/tests/storage/test_gcs.py 94.11% <0.00%> (+35.29%) ⬆️
harness/determined/common/storage/azure_client.py 83.72% <0.00%> (+37.20%) ⬆️
harness/tests/storage/test_azure.py 94.20% <0.00%> (+37.68%) ⬆️
harness/determined/common/storage/s3.py 89.61% <0.00%> (+44.15%) ⬆️
harness/determined/common/storage/cloud.py 100.00% <0.00%> (+47.36%) ⬆️
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@stoksc stoksc force-pushed the persist-debs-rpms branch from acbd278 to e3448f8 Compare May 12, 2022 20:00
@stoksc stoksc requested a review from ioga May 12, 2022 20:02
@stoksc stoksc enabled auto-merge (squash) May 13, 2022 15:14
@stoksc stoksc disabled auto-merge May 13, 2022 15:14
@stoksc stoksc merged commit ec7007c into master May 13, 2022
@stoksc stoksc deleted the persist-debs-rpms branch May 13, 2022 15:14
dzhu added a commit to dzhu/determined that referenced this pull request Dec 20, 2022
`master/dist` contains the many individual files from the output of the
docs build, which make the upload take a long time but are unnecessary
to upload at all here (the docs output is uploaded from the docs build
step). We really only want the packages from this step (see determined-ai#4124).
dzhu added a commit that referenced this pull request Dec 20, 2022
`master/dist` contains the many individual files from the output of the
docs build, which make the upload take a long time but are unnecessary
to upload at all here (the docs output is uploaded from the docs build
step). We really only want the packages from this step (see #4124).
@dannysauer dannysauer modified the milestones: 0.0.102, 0.18.1 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants