Consider using find module instead of shell

[danielkubat]

generally is not recommended to use shell module, if there is a native module in place.

current state:
https://github.com/dev-sec/ansible-os-hardening/blob/eb777fbe2f1f8677ff80b9cf5f37bedb9648476e/tasks/yum.yml#L13

using find module example:

- name: get yum-repository-files
  find:
    paths: '/etc/yum.repos.d'
    patterns: '*.repo'
  register: yum_repos

therefore in context:

- name: get yum-repository-files
  find:
    paths: '/etc/yum.repos.d'
    patterns: '*.repo'
  register: yum_repos

- name: activate gpg-check for yum-repository-files
  replace:
    dest: '{{ item.path }}'
    regexp: '^\s*gpgcheck.*'
    replace: 'gpgcheck=1'
  with_items:
    - '{{ yum_repos.files | default([]) }}'

[rndmh3ro]

Good find, you're totally right. Do you want to create a PR to fix that?

[danielkubat]

Good find, you're totally right. Do you want to create a PR to fix that?

yeah, I will create it.