Ansible Linting

[willifehler]

Description

The Ansible roles should be linted.

example:

1423 yaml[comments]: Too few spaces before comment 1424 collections/ansible_collections/devsec/hardening/roles/ssh_hardening/defaults/main.yml:109 finffine

Solution

Use https://github.com/ansible/ansible-lint and https://github.com/adrienverge/yamllint to lint all roles.

Alternatives

/

Additional information

...
/

[rndmh3ro]

We already use ansible-lint in our pipelines. See here: https://github.com/dev-sec/ansible-collection-hardening/actions/runs/7820808401/job/21336340707

Do you use an older version of the collection?

[schurzi]

We are actually already using ansible-lint, see:
https://github.com/dev-sec/ansible-collection-hardening/blob/master/.github/workflows/ansible-lint.yml
https://github.com/dev-sec/ansible-collection-hardening/actions/runs/7820808401/job/21336340707

And ansible-lint defines the spaces before comments to 1:
https://github.com/ansible/ansible-lint/blob/7849f27453fe1d9c29a43c71cff8f5b666bd43b6/src/ansiblelint/yaml_utils.py#L54

So this seems like a local issue from your setup. Maybe you have a separate config in your project/home?