-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing sysctl parameter #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about martian off the top of my head. Maybe others know this without looking it up.
See: This PR just tries to make the handling of martians consistent, we already set this parameter for all network interfaces (here), this just adds the setting for the default interface. BTW thanks for taking the time to review everything so thoroughly! |
I will add more sysctl-parameters that are missing to this PR. |
You are welcome :) I will look into this when I start using the role. Will probably take a while. |
I was about to create my own pull request for net.ipv4.conf.default.log_martians glad someone else already spotted it. Just to add to its need/requirement, the Inspec test currently checks for it https://github.com/dev-sec/linux-baseline/blob/master/controls/sysctl_spec.rb#L196. Hope this helps getting the PR progressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rndmh3ro thanks for your great work!!!
add missing sysctl parameter
Fixes #115