Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install and configure auditd - fix inspec package-08 #144

Merged
merged 10 commits into from
Jun 29, 2018
Merged

Conversation

rndmh3ro
Copy link
Member

@rndmh3ro rndmh3ro commented Aug 8, 2017

No description provided.

@rndmh3ro rndmh3ro changed the title install and configure auditd - fix inspec package-08 wip- install and configure auditd - fix inspec package-08 Aug 8, 2017
@rndmh3ro rndmh3ro changed the title wip- install and configure auditd - fix inspec package-08 install and configure auditd - fix inspec package-08 Aug 8, 2017
@rndmh3ro rndmh3ro requested review from ypid and fitz123 August 8, 2017 19:57
tasks/auditd.yml Outdated

- name: install auditd package | package-08
package:
name: '{{auditd_package}}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be '{{ auditd_package }}' :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

tasks/auditd.yml Outdated

- name: configure auditd | package-08
template:
src: 'auditd.conf.j2'
Copy link
Member

@ypid ypid Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In larger Ansible projects it quickly pays of when you recreate the directory structure also for template source files. E.g.:

    src: '/etc/audit/auditd.conf.j2'

Thats what we always do in DebOps.

Other than that I can not review this PR any further right now or approve it because I don’t know all the auditd configuration stuff added by this PR and if they are sensible defaults.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the sources.

As to the defaults of audit: these are the debian defaults, no special hardening used.

@tzumby
Copy link

tzumby commented Jun 7, 2018

This looks like an great addition, if you guys need help merging this I can volunteer!

@rndmh3ro
Copy link
Member Author

rndmh3ro commented Jun 8, 2018

@tzumby, If you're willing to test this, please go ahead and tell us the results. :) This will help in getting this merged faster.

@rndmh3ro rndmh3ro merged commit 44b3292 into master Jun 29, 2018
@rndmh3ro rndmh3ro deleted the auditd branch June 29, 2018 18:55
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
install and configure auditd - fix inspec package-08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants