-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install and configure auditd - fix inspec package-08 #144
Conversation
tasks/auditd.yml
Outdated
|
||
- name: install auditd package | package-08 | ||
package: | ||
name: '{{auditd_package}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be '{{ auditd_package }}'
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
tasks/auditd.yml
Outdated
|
||
- name: configure auditd | package-08 | ||
template: | ||
src: 'auditd.conf.j2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In larger Ansible projects it quickly pays of when you recreate the directory structure also for template source files. E.g.:
src: '/etc/audit/auditd.conf.j2'
Thats what we always do in DebOps.
Other than that I can not review this PR any further right now or approve it because I don’t know all the auditd configuration stuff added by this PR and if they are sensible defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the sources.
As to the defaults of audit: these are the debian defaults, no special hardening used.
This looks like an great addition, if you guys need help merging this I can volunteer! |
@tzumby, If you're willing to test this, please go ahead and tell us the results. :) This will help in getting this merged faster. |
install and configure auditd - fix inspec package-08
No description provided.