-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuring SELinux and default to enforcing #236
Support configuring SELinux and default to enforcing #236
Conversation
Signed-off-by: Jared Ledvina <[email protected]>
Hey @jaredledvina, this looks good and straight forward! I'd like to do some tests on all supported operating systems before merging, to see what happens on them. |
Sweet, thanks @rndmh3ro! I don't have a system currently configured w/ SELinux working but, if you'd like, I can try to make a temp DigitalOcean VM or something to make sure this works. My only concern would be that I don't know if we can ever test SELinux things like this via TravisCI unless they have a CentOS/Fedora base OS setup I'm unaware of. |
I'll just test it with the vagrant-vms - that should be enough. Of course you can test the changes, too, if you want!
Travis does not support this. Selinux testing is kind of a pain, however doing it locally and manually with vagrant usally works. |
I just tested it on CentOS 8 ans Ansible 2.8.5 and wondered why the import-task was being skipped. For me importing only worked like this:
Can you recheck on your side? |
Signed-off-by: Jared Ledvina <[email protected]>
Sorry about that! Okay so, reading through https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/facts/system/selinux.py, it looks like I can do a |
Finally came around to testing it and works great. Thank you @jaredledvina! |
…uring-selinux-status Support configuring SELinux and default to enforcing
Closes #154
I think this might do the right thing, will checkout the build though. I chose to default to
enforcing
as I don't want the defaults here to actually walk back the configuration that RHEL and friends ship with.Signed-off-by: Jared Ledvina [email protected]