Add exception in sysctl task #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
No need apply sysctl in docker and openvz containers. Signed-off-by: Oleg Kupriyanov <[email protected]>
|
Hey @okupriyanov, thanks for your PR, much appreciated. |
rndmh3ro
added a commit
that referenced
this pull request
Oct 28, 2019
|
Hey @okupriyanov, I was a little hasty in merging your PR, and needed to revert it, sorry! There are some things that need to be done additionally. For that I created a PR (https://github.com/okupriyanov/ansible-os-hardening/pull/1) against your branch. If you'd merge this we could work continue working on your PR. Sorry for the confusion! |
ghost
mentioned this pull request
rndmh3ro
added a commit
that referenced
this pull request
Jul 24, 2020
Added ssh_syslog_facility, ssh_log_level and ssh_strict_modes parameters
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Added ssh_syslog_facility, ssh_log_level and ssh_strict_modes parameters
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
No need apply sysctl in docker and openvz containers. Signed-off-by: Oleg Kupriyanov <[email protected]>
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
This reverts commit 3e14d45.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need apply sysctl in docker and openvz containers. I think that it not right. Because not all sysctls are namespaced. Docker does not support changing sysctls inside of a container that also modify the host system. As the kernel evolves we expect to see more sysctls become namespaced.
But when I run test on os-debian9-ansible-latest for example, I got many failed sysctl-* tests. Because only_if don't work for me (https://github.com/dev-sec/linux-baseline/blob/master/controls/sysctl_spec.rb#L23)