Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #247, cleanup conditions #248

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Conversation

fernandezcuesta
Copy link
Contributor

Restrict configure passwdqc and tally via central system-auth confic task for RedHat family distributions, apply NSA 2.3.3.5 Upgrade Password Hashing Algorithm to SHA-512 only when libuser is installed (regardless of OS). Cleanup of chained AND conditions for better readability.

@fernandezcuesta fernandezcuesta force-pushed the master branch 2 times, most recently from 72e7174 to 545c0dc Compare November 14, 2019 16:18
Signed-off-by: Jesús Fernández <[email protected]>
@@ -1,7 +1,7 @@
---
- name: update pam on Debian systems
command: 'pam-auth-update --package'
when: ansible_facts.distribution == 'Debian' or ansible_facts.distribution == 'Ubuntu'
when: ansible_facts.distribution in ['Debian', 'Ubuntu']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

dest: '/etc/libuser.conf'
mode: '0640'
owner: 'root'
group: 'root'
when: "'libuser' in ansible_facts.packages"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice solution! :)

@rndmh3ro rndmh3ro merged commit e674a6d into dev-sec:master Nov 16, 2019
@rndmh3ro rndmh3ro added the bug label May 5, 2020
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants