Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setLotId opcional #47

Closed
rafaelstz opened this issue Aug 20, 2024 · 7 comments
Closed

setLotId opcional #47

rafaelstz opened this issue Aug 20, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@rafaelstz
Copy link
Contributor

Quando setLotId não está especificado, o request retorna array empty. Colocando o número 1 caso não houver LotId instanciado, ajudaria a reduzir a complexidade de implementação.

Screenshot 2024-08-20 at 7 11 40 PM
@devaguia
Copy link
Owner

@rafaelstz Na classe principal do projeto eu adiciono um requestNumber padrão usando a função time(), que vai trazer o timestamp do momento da requisição. Se eu fizesse da mesma forma adicionando o 'LT' no final, resolveria para você?

Ex:
Request Number: 1724275001
Lot ID: 1724275001LT

Captura de Tela 2024-08-21 às 6 10 59 PM

@devaguia devaguia self-assigned this Aug 21, 2024
@devaguia devaguia added the enhancement New feature or request label Aug 21, 2024
@rafaelstz
Copy link
Contributor Author

sim @devaguia

@devaguia devaguia moved this from Todo to In Progress in Correios PHP Library Aug 21, 2024
@devaguia
Copy link
Owner

@rafaelstz Pode testar para mim? Inclusive os métodos de getDr e getContract da classe Authentication, fiz algumas pequenas alterações.

Estão na branch: https://github.com/devaguia/correios-php/tree/changes_1_0_3

@rafaelstz
Copy link
Contributor Author

Hey @devaguia, funcionou e os testes unitários também passaram!

Screenshot 2024-08-23 at 6 46 59 PM Screenshot 2024-08-23 at 6 47 56 PM

@devaguia
Copy link
Owner

Show @rafaelstz amanhã jogo pra master e subo a versão nova no packgist

@rafaelstz
Copy link
Contributor Author

@devaguia seria bom incluir esse bugfix na próxima versão também.
#48

@devaguia
Copy link
Owner

@rafaelstz Mandei a att agora, vou verificar e adicionar essa na próxima.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Correios PHP Library Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants