Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode plist files in XML instead of binary to mitigate App Store build crashes #31

Closed
runofthemillgeek opened this issue Apr 8, 2020 · 2 comments

Comments

@runofthemillgeek
Copy link

I'm using electron-builder to build distributables for my Electron app. Currently, app-builder is producing Info.plist files in binary format. This seems to be causing mas and mas-dev builds to crash at runtime. I'm not sure if there's any official documentation that states MAS builds should have XML formatted plists, but it is mentioned as necessary for entitlement plist files for notarization (see here).

I've detailed the steps I've taken to get working mas/mas-dev builds here: electron/osx-sign#223 (comment).

Changing the following:

err := plist.NewEncoderForFormat(&out, plist.BinaryFormat).Encode(data)

to have plist.XMLFormat passed instead should do the trick, I hope.

@wgcv
Copy link
Contributor

wgcv commented Apr 30, 2020

Please this change is very importan there are a lot of issues about this @develar

@runofthemillgeek
Copy link
Author

This should be fixed now. Thanks @wgcv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants