(feat) - replaceNode parameter #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
requested changes
Apr 21, 2019
LukasBombach
changed the title
LukasBombach
changed the title
JoviDeCroock
approved these changes
Apr 22, 2019
| expect(scratch.innerHTML).to.equal('<div id="a"></div><div id="b"></div><div id="c"></div>'); | ||
| }); | ||
|
|
||
| it('should render multiple render roots in one parentDom', () => { |
There was a problem hiding this comment.
This test is so good 👍 💯
marvinhagemeister
approved these changes
Apr 22, 2019
|
@LukasBombach Congrats on getting your first PR merged 🎉 |
|
Thank you so much! I am really happy and proud! And this feature will be so useful to us! |
|
@developit this should fix our problem with SSR in preact-cli, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation brings back the third optional parameter
replaceNodefrom8.xhttps://preactjs.com/guide/api-reference#preact-render-
With this parameter you can provide child node in your parent DOM that will be used as render root. It does not replace other children inside the parent and it will hydrate the provided node and not just replace it, the DOM nodes remain the same.
I made a more comprehensive infographic to describe why I see this as useful
https://gist.github.com/LukasBombach/884319d5430a3fb85f3b4385d7a31c89
You can try out a working usage in this repo: https://github.com/spring-media/pool-attendant (See index.partial.hydration.js)
ADDS: 16B to core