Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain and Original class name mismatch #381

Closed
AliF50 opened this issue Dec 12, 2020 · 1 comment
Closed

Plain and Original class name mismatch #381

AliF50 opened this issue Dec 12, 2020 · 1 comment

Comments

@AliF50
Copy link

AliF50 commented Dec 12, 2020

Hello,

I believe there is an issue with SourceTree, GitHub and BitBucket original and plain naming convention for colored variants. I will give GitHub as an example

I saw in a previous issue that github went from devicon-github-plain to devicon-github-original which is fine but shouldn't line 1296 of devicon.min.css be changed from .devicon-github-plain.colored, .devicon-github-plain-wordmark.colored { to .devicon-github-original.colored, .devicon-github-original-wordmark.colored {? The same can be said about SourceTree and BitBucket.

Looking forward to your response.

@amacado
Copy link
Member

amacado commented Dec 12, 2020

Hello @AliF50, you're right! And therefore it's already changed in the newest release v2.7! See the updated devicon.min.css . This is done automatically by our build process.

Regarding SourceTree and BitBucket: The font versions for this icons are broken. See this issue: #248

If you're ok with it, I will close this issue :)

@amacado amacado closed this as completed Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants