Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Post Check SVG" action is not working as expected #514

Closed
Thomas-Boi opened this issue Feb 23, 2021 · 3 comments · Fixed by #515 or #520
Closed

"Post Check SVG" action is not working as expected #514

Thomas-Boi opened this issue Feb 23, 2021 · 3 comments · Fixed by #515 or #520
Assignees
Labels
bug Use this label for pointing out bugs devops Use this label for devops related enhancements

Comments

@Thomas-Boi
Copy link
Member

In PR #513, the "Post Check SVG" action still post the wrong message. This is strange since the master branch has been updated with the new version.

Here is the old version with the incorrect name before we merge into master:
image

Here is the new version:
image

This name change was made in #509 and proves that the file has been merged into master.

I'll look more into this issue during the weekend and test it with my forked repo.

@Thomas-Boi Thomas-Boi self-assigned this Feb 23, 2021
@Thomas-Boi Thomas-Boi added bug Use this label for pointing out bugs devops Use this label for devops related enhancements labels Feb 23, 2021
@amacado
Copy link
Member

amacado commented Feb 23, 2021

There is also this failed action https://github.com/devicons/devicon/actions/runs/593486887

image

@Thomas-Boi
Copy link
Member Author

There is also this failed action https://github.com/devicons/devicon/actions/runs/593486887

This was bad design on my part. I'll have to change it later. Pretty much, what's happening is I only check for 2 results: successful run and failure.

However, there is also a third outcome: the workflow was skipped since the label is not "bot:peek". This is getting lumped into that.

There's also the bad status checks for getting the PR number. I'll have to change it to "always()" so the script will always have a PR to to.

@Panquesito7
Copy link
Member

This issue is already fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs devops Use this label for devops related enhancements
Projects
None yet
3 participants