You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Short description of the bug that you found. Provide images/code if applicable.
Some SVGs contain strokes in them, which will get ignored when Icomoon process them into icons. The SVGs are:
clojurescript-plain
matlab-line
threejs-original
threejs-original-wordmark
Note that the clojurescript and matlab had already been built. Thus, we will need to open a proper PR that will update these icons.
On a side note: the open-gl entry in the devicon.json also contained an improper aliases attribute. This causes the script to skip the open-gl SVG in the build process.
How to replicate the bug
Examine the SVGs listed above and search for stroke-width. You should see that these attributes are present in the SVGs. You can also upload the SVGs to Icomoon and see the warning message.
Possible Fixes/Solutions
Convert these SVGs so they use fills instead. The solution is listed in Icomoon FAQ. As for the open-gl issue, a simple deletion of that attribute is sufficient.
The text was updated successfully, but these errors were encountered:
For the icon fixes, I'm planning to do this in the next release. This will serve as beta testing for the new peek bot and allow me to focus on the fixes.
EDITED: Changed my mind. People might want to use the above icons. It's only fair if we address them asap
Bug
Short description of the bug that you found. Provide images/code if applicable.
Some SVGs contain strokes in them, which will get ignored when Icomoon process them into icons. The SVGs are:
Note that the
clojurescript
andmatlab
had already been built. Thus, we will need to open a proper PR that will update these icons.On a side note: the
open-gl
entry in thedevicon.json
also contained an improperaliases
attribute. This causes the script to skip theopen-gl
SVG in the build process.How to replicate the bug
Examine the SVGs listed above and search for
stroke-width
. You should see that these attributes are present in the SVGs. You can also upload the SVGs to Icomoon and see the warning message.Possible Fixes/Solutions
Convert these SVGs so they use fills instead. The solution is listed in Icomoon FAQ. As for the
open-gl
issue, a simple deletion of that attribute is sufficient.The text was updated successfully, but these errors were encountered: