Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Some SVGs contain strokes in them #788

Closed
Thomas-Boi opened this issue Aug 9, 2021 · 1 comment · Fixed by #791
Closed

Bug Report: Some SVGs contain strokes in them #788

Thomas-Boi opened this issue Aug 9, 2021 · 1 comment · Fixed by #791
Assignees
Labels
bug Use this label for pointing out bugs

Comments

@Thomas-Boi
Copy link
Member

Bug

Short description of the bug that you found. Provide images/code if applicable.
Some SVGs contain strokes in them, which will get ignored when Icomoon process them into icons. The SVGs are:

  • clojurescript-plain
  • matlab-line
  • threejs-original
  • threejs-original-wordmark

Note that the clojurescript and matlab had already been built. Thus, we will need to open a proper PR that will update these icons.

On a side note: the open-gl entry in the devicon.json also contained an improper aliases attribute. This causes the script to skip the open-gl SVG in the build process.

How to replicate the bug

Examine the SVGs listed above and search for stroke-width. You should see that these attributes are present in the SVGs. You can also upload the SVGs to Icomoon and see the warning message.

Possible Fixes/Solutions

Convert these SVGs so they use fills instead. The solution is listed in Icomoon FAQ. As for the open-gl issue, a simple deletion of that attribute is sufficient.

@Thomas-Boi Thomas-Boi added the bug Use this label for pointing out bugs label Aug 9, 2021
@Thomas-Boi Thomas-Boi self-assigned this Aug 9, 2021
@Panquesito7 Panquesito7 linked a pull request Aug 9, 2021 that will close this issue
@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Aug 9, 2021

For the icon fixes, I'm planning to do this in the next release. This will serve as beta testing for the new peek bot and allow me to focus on the fixes.

EDITED: Changed my mind. People might want to use the above icons. It's only fair if we address them asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant