Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails from dotnet publish #41

Closed
KuroThing opened this issue Jun 11, 2017 · 4 comments
Closed

Build fails from dotnet publish #41

KuroThing opened this issue Jun 11, 2017 · 4 comments

Comments

@KuroThing
Copy link

When using dotnet publish to build a .Net Core library (.Net Standard 1.3) while GitInfo is referenced, the build will fail due to attempting to download MSBuild via nuget, which exits with code 1.

It appears somewhere in the command nuget install MSBuild -outputdirectory "%user%\.nuget\packages\gitinfo\1.1.62\build\..\..\" -excludeversion -source "https://www.nuget.com/api/v2" there is something wrong that causes a "Illegal characters in path." problem.

If i had to guess whats going on, it would be that you've accidentally escaped a quote on Line 32 of GitInfo.xbuild but then that brings the question of, why does it resort to trying to use the xbuild target (Presumably Due to '$(MSBuildRuntimeVersion)' == '') when using the dotnet cli to publish a project?

I had a quick test of trying to remove the final \ to unescape the quote and the build went forward to using mono... Which isn't installed since i'm on a Windows system.

@bojanrajkovic
Copy link
Contributor

I'm hitting the same issue trying to even get the target to run w/ a .NET Core project.

@bojanrajkovic
Copy link
Contributor

OK, made some progress--the target runs if you use msbuild /t:Pack, but then the MSBuild variables it's supposed to set are all just empty. Seems like it's something about the ordering of the targets, but I'm not sure what.

@adamhathcock
Copy link

Will this fix make it work with .NET Core projects? If so, I'd love it.

@kzu kzu closed this as completed in #42 Jun 15, 2017
@bojanrajkovic
Copy link
Contributor

Yep, it should fix all things .NET Core!

@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants