-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitInfo.txt per project leaves GitSemVerPatch at zero #76
Comments
I think the dependency should be on GitVersion target, rather than GitInfo
|
Thanks for the suggestion. Using I've been scouring GitInfo.targets, but I have yet to pinpoint what's causing the variation in behavior. |
Could you share a binlog?
|
Added sample solution source here. Build output attached: |
Thanks a lot for the repro solution, I could diagnose that and push a fix. The updated nuget should be up very soon. Thanks! |
Great news. Thank you very much. |
First off, this library has been very helpful in getting our team up and running with package versioning. Thank you!
We have a single .sln with two (2) .NET Standard 2.0 class libraries. Both reference GitInfo
2.0.15
. Placing aGitInfo.txt
file in the repo root works as expected. Example, if that file includes the text "1.2.0", and there are 4 commits, we get the Sample.Library.1.2.4, and Another.Library.1.2.4.The problem comes when we try to have independent version numbers per project, via individual GitInfo.txt file per project (as mentioned here):
GitInfo.txt
for Sample.Library contents: "3.1.0"GitInfo.txt
for Another.Library contents: "2.7.0"No matter how many times we commit, the "patch" number (which is based on
$(GitSemVerPatch)
) stays at "0". For example, we expect something like "Sample.Library.3.1.4.nupkg", but get "Sample.Library.3.1.0.nupkg".Sample.Library.csproj:
Any insight into what I'm missing here would be helpful.
The text was updated successfully, but these errors were encountered: