Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts when using InternalsVisibleTo #84

Closed
drewnoakes opened this issue Nov 11, 2018 · 2 comments
Closed

Conflicts when using InternalsVisibleTo #84

drewnoakes opened this issue Nov 11, 2018 · 2 comments

Comments

@drewnoakes
Copy link

I want to add GitInfo to all projects in the solution via a Directory.Build.targets file.

Unfortunately we also use InternalsVisibleTo which results in errors due to duplicate ThisAssembly classes in global:: namespace.

The apparent workaround is to define $(ThisAssemblyNamespace), however as far as I can tell this must be done for every project, and we must remember to add it to future projects.

Is there a way to pick up the default $(RootNamespace) value? I feel like this should drop the ThisAssembly type in the project's RootNamespace by default...

@kzu
Copy link
Member

kzu commented Nov 11, 2018

Just set ThisAssemblyNamespace=RootNamespace in the Directory.Build.targets?

@drewnoakes
Copy link
Author

I ended up doing that and had some success, but got stuck on #85. Some generated files were not appearing with namespaces, and had GLOBALNAMESPACE defined, but I didn't get to a point that I was convinced there's a bug. #85 is a blocker for what I'm trying to do. If I can get past that, I'll come back to this. Closing for now. Thanks!

@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants