Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement remove-empty-folder in this project instead of using artifactory user plugin #37

Closed
zhan9san opened this issue Mar 1, 2022 · 4 comments

Comments

@zhan9san
Copy link
Contributor

zhan9san commented Mar 1, 2022

Hi @allburov

Currently, the 'remove-empty-folder' feature depends on the artifactory-user-plugins

Would it be possible to implement this feature in this project and remove the post request in delete?

If this feature is valuable, feel free to assign this task to me.

@allburov
Copy link
Member

allburov commented Mar 1, 2022

@zhan9san hi! Great idea, we can implement the second version of it that works without an external plugin.

It's not hard to add a plugin to artifactory tho...

@zhan9san
Copy link
Contributor Author

zhan9san commented Mar 2, 2022

Hi @allburov

Do we have a plan to remove this dead code?

I tried to test this feature in 7.33.9, releases-docker.jfrog.io/jfrog/artifactory-pro:latest. After the artifact was deleted, the empty folder was deleted automatically as well.

example-repo-local:a/b-3 is an empty folder.

artifactory-access.log

2022-03-02T05:37:57.634Z [53de1bddc131e037] [ACCEPTED LOGIN]   for client : admin / 10.66.40.160.
2022-03-02T05:37:58.396Z [9cb4d91621f8e354] [ACCEPTED DELETE] example-repo-local:a/b-3  for client : _system_ / .
2022-03-02T05:38:09.326Z [58281fb62248ef7d] [ACCEPTED LOGIN]   for client : jffe@000 / 127.0.0.1.

This feature was introduced in 7.8.1.

You can get details from ArtifactoryReleaseNotes-Artifactory7.8.1

RTFACT-13618 Fixed an issue whereby, the automatic cleanup process did not prune empty folders.

@allburov
Copy link
Member

allburov commented Mar 2, 2022

@zhan9san hi!
I think it's better to check Artifactory version and show a warning "Your Artifactory instance is higher then 7.8.1 and empty folders are deleted automatically here"

Personally I don't use Artifactory anymore but people can still use old versions

@zhan9san
Copy link
Contributor Author

zhan9san commented Mar 2, 2022

Hi @allburov

Thank you.

Let us leave this feature as before and I'll close this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants