Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context for storage operations #2132

Closed
nabokihms opened this issue May 20, 2021 · 3 comments · Fixed by #3941
Closed

Pass context for storage operations #2132

nabokihms opened this issue May 20, 2021 · 3 comments · Fixed by #3941

Comments

@nabokihms
Copy link
Member

Is your feature request related to a problem?

It is not related to the particular problem but the design.

Describe the solution you'd like to see

Dex has an interface for a storage. To be able to cancel long-running storage operations, we can pass context to all methods of this interface.

Describe alternatives you've considered

Leave things as they are or add any sane timeout.

Additional context

etcd storage already uses context for its operations.

@PumpkinSeed
Copy link
Contributor

I would like to work on this, but I would like to break it into smaller PRs because it will be a huge change. Breakdown means that PRs for Create, Get, List, Delete, Update - each of these will have one PR. What do you think?

@sagikazarmark
Copy link
Member

Sounds good! Thanks for taking the effort.

@bobmaertz
Copy link
Contributor

I'd love to work on this and help push it over the finish line if its available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants