From 39193ca1ecd85130b85de297861284a059986538 Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Mon, 10 Feb 2025 16:19:55 +0100 Subject: [PATCH] docs: review Icrc2ApproveRequest jsdocs types Signed-off-by: David Dal Busco --- packages/ledger-icp/src/types/ledger_converters.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/ledger-icp/src/types/ledger_converters.ts b/packages/ledger-icp/src/types/ledger_converters.ts index 87ccc915b..9e7e82415 100644 --- a/packages/ledger-icp/src/types/ledger_converters.ts +++ b/packages/ledger-icp/src/types/ledger_converters.ts @@ -43,12 +43,12 @@ export type Icrc1TransferRequest = { * * @param {Account} spender The account of the spender. * @param {Tokens} amount The amount of tokens to approve. - * @param {Subaccount?} from_subaccount The subaccount to transfer tokens from. - * @param {Uint8Array|number?} icrc1Memo Approve memo. - * @param {Timestamp?} created_at_time nanoseconds since unix epoc to trigger deduplication and avoid other issues - * @param {Tokens?} fee The fee of the transfer when it's not the default fee. - * @param {Tokens?} expected_allowance The optional allowance expected. If the expected_allowance field is set, the ledger MUST ensure that the current allowance for the spender from the caller's account is equal to the given value and return the AllowanceChanged error otherwise. - * @param {Timestamp?} expires_at When the approval expires. If the field is set, it's greater than the current ledger time. + * @param {SubAccount?} from_subaccount The subaccount to transfer tokens from. + * @param {Uint8Array?} icrc1Memo Approve memo. + * @param {Icrc1Timestamp?} createdAt nanoseconds since unix epoc to trigger deduplication and avoid other issues + * @param {Icrc1Tokens?} fee The fee of the transfer when it's not the default fee. + * @param {Icrc1Tokens?} expected_allowance The optional allowance expected. If the expected_allowance field is set, the ledger MUST ensure that the current allowance for the spender from the caller's account is equal to the given value and return the AllowanceChanged error otherwise. + * @param {Icrc1Timestamp?} expires_at When the approval expires. If the field is set, it's greater than the current ledger time. */ export type Icrc2ApproveRequest = Omit & { expected_allowance?: Icrc1Tokens;