Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Using FactoryGirl closer to its intended way of being used #49

Open
dflionis opened this issue Feb 19, 2017 · 0 comments
Open

Start Using FactoryGirl closer to its intended way of being used #49

dflionis opened this issue Feb 19, 2017 · 0 comments
Assignees

Comments

@dflionis
Copy link
Owner

dflionis commented Feb 19, 2017

In anticipation of a massive PR being merged to master that contains a lot of spaghetti-like factories, we need to make it a point in the future to clean up the factory directory. We're currently trying to recreate our real world universe in FactoryGirl which creates dependencies that FactoryGirl is not made to handle. Instead of putting players on the wrong teams in the specs in order to prevent collisions, we should make the factories more dynamic so that they always create new objects through their complex web of associations.

@dflionis dflionis self-assigned this Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant