From ae8929ebf7e20270a750094e1a75655bb9edcc05 Mon Sep 17 00:00:00 2001 From: Vincent Auger Date: Mon, 23 Dec 2024 15:22:28 -0400 Subject: [PATCH 01/11] feat(seeder): add editor and chief editor users to LocalTestDataSeeder fix(locales): update 'ready-to-marked-published' text for clarity in English and French refactor: remove duplicate import statement in ManuscriptRecordPage.vue refactor: clean up imports in CreatePublicationDialog.vue --- database/seeders/LocalTestDataSeeder.php | 14 ++++++++++++++ resources/src/locales/en.json | 2 +- resources/src/locales/fr.json | 2 +- .../views/ManuscriptRecordPage.vue | 2 +- .../components/CreatePublicationDialog.vue | 2 +- 5 files changed, 18 insertions(+), 4 deletions(-) diff --git a/database/seeders/LocalTestDataSeeder.php b/database/seeders/LocalTestDataSeeder.php index c732c6ab..1d6b06b3 100644 --- a/database/seeders/LocalTestDataSeeder.php +++ b/database/seeders/LocalTestDataSeeder.php @@ -23,6 +23,20 @@ public function run(): void JournalsTableSeeder::class, ]); + // create an editor user + \App\Models\User::factory()->editor()->create([ + 'first_name' => 'Editor', + 'last_name' => 'User', + 'email' => 'editor@test.local' + ]); + + // create an chief editor user + \App\Models\User::factory()->chiefEditor()->create([ + 'first_name' => 'Chief Editor', + 'last_name' => 'User', + 'email' => 'chief.editor@test.local' + ]); + // create a blank slate user \App\Models\User::factory()->create([ 'email' => 'new@test.local', diff --git a/resources/src/locales/en.json b/resources/src/locales/en.json index c9907222..718d0799 100644 --- a/resources/src/locales/en.json +++ b/resources/src/locales/en.json @@ -521,7 +521,7 @@ "pls-text": "Plain Language Summary (PLS) of the manuscript to explain the relevance of the science to the Department and to promote the value of science through outreach and communication. It is intended for internal use to identify linkages to programs, policies and stakeholders and for use in the plain language promotion of science.", "potential-media-interest-question": "Is this manuscript of potential public interest?", "potential-media-interest-text-field-text": "Optionally, please provide any pertinent information concerning the potential public interest.", - "ready-to-marked-published": "This manuscript has been reviewed but still needs to be marked as published by the applicant.", + "ready-to-marked-published": "This manuscript has completed its management review but still needs to be marked as submitted and accepted to a thrid-party Journal by the applicant.", "relevant-text": "Describe how this manuscript is relevant to the program that funded it, how it supports the department's mandate, strategic plan and or/regional priorities. ", "relevant-title": "Relevance to programs/initiatives/client sector", "replace-manuscript": "Upload a new version of the manuscript", diff --git a/resources/src/locales/fr.json b/resources/src/locales/fr.json index 25de731e..67fea2f5 100644 --- a/resources/src/locales/fr.json +++ b/resources/src/locales/fr.json @@ -521,7 +521,7 @@ "pls-text": "Résumé en langage clair du manuscrit pour expliquer la pertinence de la science pour le Département et promouvoir la valeur de la science par la sensibilisation et la communication. \nIl est destiné à un usage interne pour identifier les liens avec les programmes, les politiques et les intervenants et à être utilisé dans la promotion de la science en langage clair.", "potential-media-interest-question": "Ce manuscrit présente-t-il un intérêt public potentiel?", "potential-media-interest-text-field-text": "Facultativement, veuillez fournir toute information pertinente concernant l'intérêt public potentiel.", - "ready-to-marked-published": "Ce manuscrit a été révisé mais doit encore être marqué comme publié par le candidat.", + "ready-to-marked-published": "Ce manuscrit a terminé sa revue par la gestion mais doit encore être marqué comme soumis et accepté dans une revue tierce par le demandeur.", "relevant-text": "Décrivez comment ce manuscrit est pertinent pour le programme qui l'a financé, comment il supporte le mandat du ministère, le plan stratégique du département et/ou les priorités régionales. ", "relevant-title": "Pertinence par rapport aux programmes/initiatives/clients ", "replace-manuscript": "Télécharger une nouvelle version du manuscrit", diff --git a/resources/src/models/ManuscriptRecord/views/ManuscriptRecordPage.vue b/resources/src/models/ManuscriptRecord/views/ManuscriptRecordPage.vue index 062faf09..e546d288 100644 --- a/resources/src/models/ManuscriptRecord/views/ManuscriptRecordPage.vue +++ b/resources/src/models/ManuscriptRecord/views/ManuscriptRecordPage.vue @@ -1,7 +1,7 @@