Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critical: on error you need to exit with status code != 0 #148

Closed
cr1st1p opened this issue Aug 27, 2021 · 0 comments
Closed

critical: on error you need to exit with status code != 0 #148

cr1st1p opened this issue Aug 27, 2021 · 0 comments

Comments

@cr1st1p
Copy link

cr1st1p commented Aug 27, 2021

Version: ?.?.?

Bug Description

I'm using this in a pipeline. Somehow I ended with a bad password. Script showed the error but pipeline continued.
Meaning that script did not exit with error code != 0.
I see that you catch exceptions, print it, and... just continue and do a return 0 :-/

Steps To Reproduce

Expected Behavior

I would expect script to return non zero error code on errors

Possible Solution

... Only if you have suggestions on a fix for the bug

@dg dg closed this as completed in 49e23b2 Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant