Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic property is deprecated #163

Closed
laurentmuller opened this issue May 19, 2023 · 0 comments
Closed

Dynamic property is deprecated #163

laurentmuller opened this issue May 19, 2023 · 0 comments

Comments

@laurentmuller
Copy link
Contributor

PHAR Version: 3.5.0
PHP Version: 8.2.5

Bug Description

When I deploy my application to local, the FileServer class is used.

The following exception is throw:

Error: Creation of dynamic property Deployment\FileServer::$filePermissions is deprecated in phar://deployment.phar/src/Deployment/CliRunner.php:2

Steps To Reproduce

Simply deploy to local with the following deploy file properties:

[symphony]
remote = file://D:/local/production

Expected Behavior

No error must be raised.

Possible Solution

Maybe we can update the FileServer class by adding the following attribute:

#[AllowDynamicProperties]
@laurentmuller laurentmuller changed the title Ddynamic property is deprecated i Dynamic property is deprecated May 19, 2023
@hdcore hdcore mentioned this issue Mar 16, 2024
Closed
@dg dg closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #163 - permissions should not be set for FileServer
2 participants
@dg @laurentmuller