Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION]: When will there be a new release (v2 to maintain compatibility with libraries using the old version)? #386

Closed
flymedllva opened this issue Jul 31, 2024 · 5 comments
Assignees
Labels
kind/question Something requiring a response. ristretto

Comments

@flymedllva
Copy link
Contributor

Question.

The library has not received a new release (tag) for a long time, although many bugs have been fixed, generics have been added (breaking compatibility of packages using ristretto).
When will there be a release?

@flymedllva flymedllva added the kind/question Something requiring a response. label Jul 31, 2024
@flymedllva
Copy link
Contributor Author

flymedllva commented Aug 2, 2024

Generics appearing in ristretto break compatibility of packages not updated to the new version of ristretto
Since ristretto can be used in libraries...
The new tag doesn't seem to save this situation and we should do github.com/dgraph-io/ristretto/v2 to avoid breaking compatibility with libraries using the old version without generics.

@flymedllva flymedllva changed the title [QUESTION]: When will there be a new release (tag)? [QUESTION]: When will there be a new release (v2 to maintain compatibility with libraries using the old version)? Aug 2, 2024
Copy link
Contributor

Good point. We're working on cutting releases prior to and after this change. Moving forward, we'll get on a routine release cadence.

@verkaufer
Copy link

@ryanfoxtyler Also interested in getting an officially tagged release for this library and then getting https://github.com/dgraph-io/badger updated with the tagged dependency.

I was running into conflicts using BadgerDB alongside ory/fosite because it doesn't (yet) use the proper generic instantiation syntax. I couldn't downgrade ristretto to an earlier version either because BadgerDB needed something greater than 0.11.0 :)

@jchappelow
Copy link

The new tag doesn't seem to save this situation and we should do github.com/dgraph-io/ristretto/v2 to avoid breaking compatibility with libraries using the old version without generics.

Completely agree. I just saw this issue after reporting our trouble with badger and generics in #394 (comment)

@mangalaman93
Copy link
Contributor

We just pushed released for badger https://github.com/dgraph-io/badger/releases/tag/v4.3.1 and ristretto https://github.com/dgraph-io/ristretto/releases/tag/v1.0.0. Badger v4.3.1 uses the latest v1.0.0 ristretto. I am going to close this issue but feel free to reopen if needed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Something requiring a response. ristretto
Development

No branches or pull requests

5 participants