Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE]: Update Dockerfile and test with Node 20 (#34) #40

Closed
5 of 7 tasks
dgrebb opened this issue Oct 25, 2023 · 1 comment
Closed
5 of 7 tasks

[CHORE]: Update Dockerfile and test with Node 20 (#34) #40

dgrebb opened this issue Oct 25, 2023 · 1 comment
Assignees
@dgrebb
Labels
chores Maintenance and other feature-unrelated tasks. dependencies
Milestone
Node Support (>=1...

Comments

@dgrebb
Copy link
Owner

dgrebb commented Oct 25, 2023 •
edited
Loading

The BackstopJS Dockerfile should be updated to and adjust for any Node 20 compatibility issues.

  • Update Dockerfile
  • Adjust any related configuration
  • Test all scenarios

Docker Validations Performed

Note: a npm run docker-load script was added to load local buildx multi-platform image without publishing

  • cd test/configs/ && node ../../cli/index.js test --docker
  • npm run sanity-test-docker
  • npm run smoke-test-docker - exits without indication of passing smoke tests; report opens in browser. expected?
  • npm run sanity-test-playwright-docker
@dgrebb dgrebb added chores Maintenance and other feature-unrelated tasks. dependencies labels Oct 25, 2023
@dgrebb dgrebb added this to the Node Support (>=18.0.0) milestone Oct 25, 2023
This was referenced Oct 25, 2023
Open
Closed
@dgrebb dgrebb self-assigned this Nov 26, 2023
@dgrebb dgrebb closed this as completed Dec 15, 2023
@dgrebb dgrebb reopened this Dec 15, 2023
@dgrebb
Copy link
Owner Author

dgrebb commented Dec 15, 2023

garris#1523

@dgrebb dgrebb closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgrebb dgrebb

Labels
chores Maintenance and other feature-unrelated tasks. dependencies
Projects
None yet
Milestone
Node Support (>=18.0.0)
Development

No branches or pull requests
1 participant
@dgrebb