fix(homebridge): prevent undefined brightness for alarms

Closes #1057
dgreif · Oct 2, 2022 · 08aa0ea · 08aa0ea
1 parent 35f1932
commit 08aa0ea
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/homebridge/brightness-only.ts b/homebridge/brightness-only.ts
@@ -16,13 +16,16 @@ export class BrightnessOnly extends BaseDeviceAccessory {
     const { Characteristic, Service } = hap,
       { context } = accessory
 
-    if ('brightness' in device.data && !isNaN(device.data.brightness!)) {
+    if (
+      device.data.brightness !== undefined &&
+      !isNaN(device.data.brightness)
+    ) {
       this.registerLevelCharacteristic({
         characteristicType: Characteristic.Brightness,
         serviceType: Service.Lightbulb,
         getValue: (data) => {
           if (!data.brightness || isNaN(data.brightness)) {
-            return undefined
+            return 0
           }
 
           // store the brightness so that we can set it again if light is turned off then back on