Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fans #94

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Add support for fans #94

merged 2 commits into from
Aug 7, 2019

Conversation

smockle
Copy link
Collaborator

@smockle smockle commented Aug 3, 2019

Fan control switches, such as the GE 14287, can be added to the Ring Alarm Base Station via “Devices > Set Up a Device > Security Devices > Works With Ring”.

Once the device is added, the Ring app prompts you to select a category (options are “Fans”, “Lights” and “Outlets”) (screenshot below):
IMG

Homebridge supports a Fan Service. This PR enables the homebridge-ring plugin to identify fan control devices as Fans to HomeKit.

Without this PR, the plugin identifies these devices as dimmable lights. This is because Ring reuses the switch.multilevel deviceType for both fans and (multi-level) switches. This PR differentiates the two device types by using the value of categoryId. Fans and multi-level switches have categoryId 17 and 2, respectively. This can be seen by modifying examples/example.ts line 47 to log the entire device object with JSON.stringify(device).

I published [email protected] for testing. Additional screenshots below:

Ring app Home app
IMG_1140 IMG_1141

@dgreif
Copy link
Owner

dgreif commented Aug 7, 2019

@smockle thank you for the PR! Everything looks great, I'll just need to do some additional steps to ensure compatibility if there was already a Lightbulb service created. The really ironic part is that I have that exact GE switch which I am using for a fan and didn't realize that Ring had the categories you could choose from 🤦‍♂. Really appreciate the help!

@dgreif dgreif merged commit 15cca9a into dgreif:master Aug 7, 2019
@dgreif
Copy link
Owner

dgreif commented Aug 8, 2019

@smockle released in v5.4.0. Let me know how it works for you after the upgrade. It should automatically remove the light and add a fan

@smockle smockle deleted the support-fans branch August 9, 2019 03:31
@smockle
Copy link
Collaborator Author

smockle commented Aug 9, 2019

@dgreif Thanks for the update! I upgraded to 5.4.0 last night, and it’s working well here.

@smockle smockle mentioned this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants