Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] An option to prevent diff page from opening in a new tab #2839

Open
OPerepadia opened this issue Dec 15, 2024 · 3 comments
Open

[feature] An option to prevent diff page from opening in a new tab #2839

OPerepadia opened this issue Dec 15, 2024 · 3 comments
Labels
enhancement New feature or request user-interface

Comments

@OPerepadia
Copy link

OPerepadia commented Dec 15, 2024

Version and OS
0.48.01 on linux/docker

Is your feature request related to a problem? Please describe.
Hi. Currently, when I left click on History button, it opens a new tab.

Describe the solution you'd like
Ideally I would like an option to prevent history page from opening in a new tab. But if anyone can suggest a workaround that will work for Firefox on Linux and Android, I will be grateful.

Describe the use-case and give concrete real-world examples
Whenever I click on history button, it opens diff viewer in a new tab, so that after I'm done reviewing the changes, I have to close this tab. It would be more convenient if it opened in the same tab, so I could simply use the back button or click on the top title bar to return to the main page without having to close a new tab every time.

Additional context
I can reproduce this behavior in Firefox and Chromium on linux, as well as Firefox on Android.

@OPerepadia OPerepadia added the enhancement New feature or request label Dec 15, 2024
@dgtlmoon
Copy link
Owner

Yeah, actually there was a lot of people who argued that it SHOULD open in a new tab :) quite some time ago

so a UI options tab would be handy

@OPerepadia
Copy link
Author

OPerepadia commented Dec 28, 2024

I've added an option to disable opening the diff page in a new tab. I did some tests and it seems to work as expected. It's enabled by default to keep the current behavior.
Would it be okay if I open a PR?

image

@OPerepadia
Copy link
Author

OPerepadia commented Dec 28, 2024

Or should I create a separate tab for such UI options, like you initially suggested?
Because I would also like to add an option to open screenshot view by default instead of text view (in case Playwright/WebDriver is enabled).

@OPerepadia OPerepadia changed the title [feature] An option to prevent "History" page from opening in a new tab [feature] An option to prevent diff page from opening in a new tab Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user-interface
Projects
None yet
Development

No branches or pull requests

2 participants