Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post:// posts:// gets:// etc notification paths are double-encoded #2868

Open
duozmo opened this issue Dec 29, 2024 · 3 comments
Open

post:// posts:// gets:// etc notification paths are double-encoded #2868

duozmo opened this issue Dec 29, 2024 · 3 comments
Assignees
Labels
bug Something isn't working Notifications systems Development of notifications of changes triage upstream-bug issue with library - not directly with changedetection

Comments

@duozmo
Copy link

duozmo commented Dec 29, 2024

Describe the bug
If you use a notification path with a space or escape sequence, such as:

  • posts://example.com/my endpoint
  • posts://example.com/my%20endpoint

Then the notification will be sent to:

posts://example.com/my%2520endpoint

This will likely fail with a 404 or other error, due to the % being encoded as %25.

Version
v0.48.05

How did you install?
Docker Compose

To Reproduce

Steps to reproduce the behavior:

  1. Go to notification settings on a watch
  2. Set the URL to something with a space or escape sequence, such as posts://example.com/my%20endpoint
  3. Push Send test notification
  4. Note that notification is not delivered

Example watch: https://changedetection.io/share/0U5lJwB5bmQa

Expected behavior
The notification should be delivered to the supplied path, e.g. my%20endpoint instead of my%2520endpoint.

Desktop (please complete the following information):

  • OS: Ubuntu 22.04.3 LTS
  • Browser: Vivaldi
  • Version 7.0

Additional context
The notification log will show the user-supplied URL (i.e. will not show the problem). This was discovered by wrapping the outbound request in a log statement.

@dgtlmoon
Copy link
Owner

thanks! is it only posts:// post:// or is it others aswell?

@dgtlmoon
Copy link
Owner

I reduced the bug to a few lines of code and registered the upstream issue here caronc/apprise#1264

@dgtlmoon dgtlmoon added bug Something isn't working Notifications systems Development of notifications of changes upstream-bug issue with library - not directly with changedetection labels Dec 29, 2024
@dgtlmoon dgtlmoon changed the title Notification paths are double-encoded post:// posts:// gets:// etc notification paths are double-encoded Dec 29, 2024
@duozmo
Copy link
Author

duozmo commented Dec 29, 2024

Perfect, thanks. I'll follow that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Notifications systems Development of notifications of changes triage upstream-bug issue with library - not directly with changedetection
Projects
None yet
Development

No branches or pull requests

2 participants