-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify noxfile.py::_cmake
so it works with nox --install-only
#224
Comments
I'm (sort of) happy to see that the if self._runner.global_config.install_only:
logger.info("Skipping {} run, as --install-only is set.".format(args[0]))
return None |
I can think of at least two options here:
I don't like either one. Both assume some level of knowledge of implementation details, so they can bitrot over time if The second one somehow seems more appealing, however by monkey-patching a global value, we ruin the ability for the config to be used concurrently by other @theacodes WDYT? |
tbh I'd be happy to see a |
noxfile.py::_cmake
to it works with nox --install-only
noxfile.py::_cmake
so it works with nox --install-only
@theacodes Good idea. I love when teamwork works (i.e. my brain didn't go there at all)! Will send a PR soon. |
Sent: wntrblm/nox#331 |
The usage of
session.run
means the later
session.install(".", env=env)
ininstall_bezier()
doesn't work as expected when--install-only
is used.The text was updated successfully, but these errors were encountered: