From f931544651e8149c65d5b080c97f23d7b2142896 Mon Sep 17 00:00:00 2001 From: Kai Vandivier Date: Mon, 13 Jan 2025 17:41:26 +0100 Subject: [PATCH] chore: remove some todos --- examples/simple-app/src/PluginTester.jsx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/examples/simple-app/src/PluginTester.jsx b/examples/simple-app/src/PluginTester.jsx index 2b8c863b..c5b53670 100644 --- a/examples/simple-app/src/PluginTester.jsx +++ b/examples/simple-app/src/PluginTester.jsx @@ -21,7 +21,7 @@ const PluginTester = () => { return (
- {/* Todo: 1. Container-driven default */} + {/* 1. Container-driven default */}

Container-driven default. Expectation: fills container width, height = content height. A wrapper div is needed to make margins @@ -55,8 +55,7 @@ const PluginTester = () => {

- {/* Todo: 4. Content-driven option */} - {/* To do: error screen breaks sizing */} + {/* 4. Content-driven option */}

Content-driven size. Expectation: width is defined by content; iframe grows and shrinks @@ -67,8 +66,6 @@ const PluginTester = () => { clientWidth="max-content" /> - {/* Todo: is there a time when we would need to specify height? 🤔 */} - {/* 5. Flex horizontal */} {/* Currently working */}

@@ -87,7 +84,7 @@ const PluginTester = () => {

- {/* Todo: 6. Flex vertical */} + {/* 6. Flex vertical */} {/* Currently working; height is still getting set by the resize observer, but className styles are overriding them */}

Flex vertical. Expectation: iframe resizes vertically according