Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commands): move jscodeshift to regular dependencies #122

Merged

Conversation

HendrikThePendric
Copy link
Contributor

jscodeshift is not a dev dependency as it is used in the install command

@HendrikThePendric HendrikThePendric requested review from amcgee and a user January 4, 2021 14:43
@HendrikThePendric HendrikThePendric self-assigned this Jan 4, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, your change looks correct to me 👍

@HendrikThePendric HendrikThePendric marked this pull request as draft January 4, 2021 15:37
@HendrikThePendric HendrikThePendric changed the base branch from master to next January 5, 2021 15:29
@HendrikThePendric HendrikThePendric marked this pull request as ready for review January 5, 2021 15:29
@HendrikThePendric HendrikThePendric force-pushed the CLI-21-make-jscodeshift-a-regular-dependency branch from ee018e9 to 26adf57 Compare January 6, 2021 12:00
@HendrikThePendric HendrikThePendric merged commit 05d9909 into next Jan 6, 2021
@HendrikThePendric HendrikThePendric deleted the CLI-21-make-jscodeshift-a-regular-dependency branch January 6, 2021 12:06
dhis2-bot added a commit that referenced this pull request Jan 6, 2021
## [5.0.3](v5.0.2...v5.0.3) (2021-01-06)

### Bug Fixes

* **commands:** move jscodeshift to regular dependencies ([#122](#122)) ([05d9909](05d9909))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants