Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS setup-python python binary not used #122

Closed
egpbos opened this issue Jan 19, 2022 · 6 comments
Closed

macOS setup-python python binary not used #122

egpbos opened this issue Jan 19, 2022 · 6 comments

Comments

@egpbos
Copy link
Member

egpbos commented Jan 19, 2022

It seems like in macOS builds, we are somehow using the setup-python action wrong. The version that is installed is not picked up in the version check right thereafter and also not in the later commands where we install dependencies and DIANNA itself. In effect, we have been using only the macOS system provided Python 3.9 for a while now.

Right now, this is causing an issue, because for some weird reason it complains about bdist_wheels, for instance in this build. Note that I didn't change anything in the build there, so it seems to really be caused by external factors.

@loostrum
Copy link
Member

loostrum commented Jan 19, 2022

That complaint would happen if the system python doesn't have wheel installed, which might be the case I guess.

I see e.g. in this action by the way that while the python info shows the wrong version, the unit tests are using the right version.

Could it be that only the python executable is the newly installed version, while python3 still points to the system version? Both the wheel build and python info use python3 explicitly.

@egpbos
Copy link
Member Author

egpbos commented Jan 19, 2022

I'll try!

@egpbos
Copy link
Member Author

egpbos commented Jan 19, 2022

Argh, nope, this works on Linux and Windows, but on macOS python points to the system Python 2...

@egpbos
Copy link
Member Author

egpbos commented Jan 19, 2022

Oh, damn, I think it is caused by a minor edit of mine, haha. I added shell: bash -l {0} to the run things, which apparently causes problems: actions/setup-python#179

@loostrum
Copy link
Member

Ah nice catch!

@egpbos
Copy link
Member Author

egpbos commented Jan 20, 2022

Fixed by removing the -l option to bash.

@egpbos egpbos closed this as completed Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants