-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Cointracking.info import #158
Comments
Thanks for the request! Do you have a sample export that I can use to build this? |
CoinTracking_Trade_Table_export_example.csv |
I created an initial version of the converter based on the example you provided. This now supports buy and sell records. I think staking rewards can also be added (like dividends). Can you create staking reward transaction and send it to me, so I can add it? Thanks! Also, here is a version of the converter. Can you test it for me? Finally, can you provide me with instructions on how to make a CSV export, so I can add this to the README? |
CoinTracking Trade Table Test.csv Here is a new export, i added an Income -> Staking example. Further will follow shortly. |
How to make an export
|
Thanks, I will add the staking tonight, as well as updating the README. I'm looking forward to your test results! |
So for the first file i posted, the import seemed to work fine, but the second file i posted today throws an exception when converting.
|
This means your second file has more columns then currently expected. Can you send me a part of this new file so I can check? |
i used the file posted here |
I see, that one doesn't seem to have a "Tx-ID" colum, which the initial one had. |
@jameskitt616 For some reason the date format also changed from "2025-01-01 10:12:27" to "18.01.2025 15:18:55". Did you change anything while exporting that could cause these differences? |
Hm, there is CSV and CSV (full export), seems like those two are different. Here is the Full export version. |
Thanks. I will continue today and let you know when it's ready to test! |
I just added the Tx-ID back, and updated the instructions in the README. Can you verify if you can use it now using this Docker image? Thanks! |
Seems to work, i only noticed that the Staking doesnt have any Unit Price, thus no Value after importing. |
This is due to there being no value to compare with. I can set it to 1, maybe that will work? You can check with this Docker image. |
@jameskitt616 Did you by chance take a look? |
I tried it and i am actually a bit more confused with ghostfolio right now, i dont understand why dividend counts towards the Overview or total amount for an Account. |
Any update on this? Is this a ghostfolio thing, or should there be done more on this tool? Otherwise I’d like to merge the change. Thanks! |
The behavior seems to be the exact same if i add a dividend manually. So from my understanding i think this MR should be fine and does what it's supposed to do. |
Enabling support for https://cointracking.info/ would be a great option for people who wrote down their trades for years there.
The text was updated successfully, but these errors were encountered: