Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gene name annotations not included in final results #46

Closed
fklirono opened this issue Jan 8, 2018 · 3 comments
Closed

gene name annotations not included in final results #46

fklirono opened this issue Jan 8, 2018 · 3 comments
Assignees
Labels

Comments

@fklirono
Copy link

fklirono commented Jan 8, 2018

DCC version 0.4.4
GENCODE v27 annotation for GRCh38
STAR 2.5.3a indexed GRCh38 with GENCODE v27 annotation

I run DCC after mapping the stranded paired-end ribodepleted RNAseq data in the three passes described in the manual (both mates, mate1, mate2):

DCC both_Chimeric.out.junction -mt1 mate1_Chimeric.out.junction -mt2 mate2_Chimeric.out.junction -O ./dcc -t ./dcc/_tmp -D -R /data/annotations/GRCh38/rpmk+simple_repeats.gtf -an /data/annotations/GRCh38/GRCh38.gencode.v27.gtf -k -T 16 -Pi -F -M -fg -Nr 1 1 -G -A /data/genomes/GRCh38/GRCh38.fa -B ./both_Aligned.sortedByCoord.out.bam

However, in the final result file CircCoordinates the circRNAs detected are not annotated (there is a dot (.) in the Gene column), whereas the temporary file tmp_coordinates_annotated has all detected and unfiltered circRNAs correctly annotated. It seems that somehow this annotation is not transferred to the filtered and final results?

@fklirono
Copy link
Author

fklirono commented Jan 9, 2018

I think I have found the bug! Checking out v0.4.4 I see on main.py you have commented out lines 274-275 which rename tmp_coordinates_annotated to tmp_coordinates so that it can be picked up by the Filtering module.

When I run DCC without Filtering activated then the circRNAs are correctly annotated.

Reading over your code I discovered another bug. Your "hidden" -ss option defaults to False, whereas your -N option defaults to True although you indent DCC to run by default in stranded mode. So effectively it runs by default in unstranded mode.
EDIT: this is not correct, the -ss flag defines fr-firststrand synthesis for stranded data and the -N flag sets options.strand to FALSE.

@tjakobi tjakobi added the bug label Jan 10, 2018
@tjakobi tjakobi self-assigned this Jan 10, 2018
@tjakobi
Copy link
Contributor

tjakobi commented Jan 15, 2018

Hi @fklirono,

thank you for your report. It probably makes sense to release a new version soon due to the number of fixes not included in the current stable release.

However, from your reply I assume that using the most current master branch does fix the error for you?

Cheers,
Tobias

@fklirono
Copy link
Author

Hi,

yes, DCC seems to work properly now. I will freeze it in my pipeline for now.

Thanks for the good work!

@tjakobi tjakobi closed this as completed Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants