diff --git a/src/main/java/com/diffplug/gradle/spotless/java/JavaExtension.java b/src/main/java/com/diffplug/gradle/spotless/java/JavaExtension.java index da90be1885..23a40817e8 100644 --- a/src/main/java/com/diffplug/gradle/spotless/java/JavaExtension.java +++ b/src/main/java/com/diffplug/gradle/spotless/java/JavaExtension.java @@ -81,7 +81,7 @@ protected void setupTask(FormatTask task) throws Exception { } UnionFileCollection union = new UnionFileCollection(); for (SourceSet sourceSet : javaPlugin.getSourceSets()) { - union.add(sourceSet.getJava()); + union.add(sourceSet.getAllJava()); } target = union; } diff --git a/src/test/java/com/diffplug/gradle/spotless/java/JavaDefaultTargetTest.java b/src/test/java/com/diffplug/gradle/spotless/java/JavaDefaultTargetTest.java new file mode 100644 index 0000000000..a1f2708b37 --- /dev/null +++ b/src/test/java/com/diffplug/gradle/spotless/java/JavaDefaultTargetTest.java @@ -0,0 +1,61 @@ +/* + * Copyright 2016 DiffPlug + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.diffplug.gradle.spotless.java; + +import java.io.IOException; + +import org.junit.Assert; +import org.junit.Test; + +import com.diffplug.gradle.spotless.GradleIntegrationTest; + +public class JavaDefaultTargetTest extends GradleIntegrationTest { + @Test + public void integration() throws IOException { + write("build.gradle", + "plugins {", + " id 'com.diffplug.gradle.spotless'", + "}", + "repositories { mavenCentral() }", + "", + "apply plugin: 'groovy'", + "", + "spotless {", + " java {", + " googleJavaFormat()", + " }", + "}"); + String input = getTestResource("java/googlejavaformat/JavaCodeUnformatted.test"); + write("src/main/java/test.java", input); + write("src/main/groovy/test.java", input); + write("src/main/groovy/test.groovy", input); + + // write appends a line ending so re-read to see what groovy currently looks like + String groovyInput = read("src/main/groovy/test.groovy"); + + gradleRunner().forwardOutput().withArguments("spotlessApply").build(); + + String result = read("src/main/java/test.java"); + String output = getTestResource("java/googlejavaformat/JavaCodeFormatted.test"); + Assert.assertEquals("Java code in the java directory should be formatted.", output, result); + + result = read("src/main/groovy/test.java"); + Assert.assertEquals("Java code in the groovy directory should be formatted.", output, result); + + result = read("src/main/groovy/test.groovy"); + Assert.assertEquals("Groovy code in the groovy directory should not be formatted.", groovyInput, result); + } +}