You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a stylistic opinion, but if we are going to change it now is the time, to minimize refactoring later.
Currently the MapeoManager methods for invites are namespaced under mapeoManager.invite. This feels unnecessary given that nothing else on MapeoManager is namespaced, and now that we have events on the mapeoManager instance itself (local-peers), it could cause developer confusion trying to remember which events are emitted by mapeoManager and which events are emitted by mapeoManager.invite.
There are only two methods, I suggest we change them to:
manager.acceptInvite()
manager.rejectInvite()
And we change the event 'invite-received' to be emitted from the manager instance directly.
This is a stylistic opinion, but if we are going to change it now is the time, to minimize refactoring later.
Currently the MapeoManager methods for invites are namespaced under
mapeoManager.invite
. This feels unnecessary given that nothing else on MapeoManager is namespaced, and now that we have events on themapeoManager
instance itself (local-peers
), it could cause developer confusion trying to remember which events are emitted bymapeoManager
and which events are emitted bymapeoManager.invite
.There are only two methods, I suggest we change them to:
manager.acceptInvite()
manager.rejectInvite()
And we change the event
'invite-received'
to be emitted from themanager
instance directly.@achou11 thoughts?
The text was updated successfully, but these errors were encountered: