Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc-lib-9.2.3.20220527 doesn't build on GHC 8.10 when -haddock is enabled #391

Closed
kokobd opened this issue Jul 3, 2022 · 4 comments · Fixed by #392
Closed

ghc-lib-9.2.3.20220527 doesn't build on GHC 8.10 when -haddock is enabled #391

kokobd opened this issue Jul 3, 2022 · 4 comments · Fixed by #392

Comments

@kokobd
Copy link

kokobd commented Jul 3, 2022

Seems related to #344.

[103 of 357] Compiling GHC.CmmToAsm.AArch64.CodeGen ( compiler/GHC/CmmToAsm/AArch64/CodeGen.hs, dist/build/GHC/CmmToAsm/AArch64/CodeGen.o, dist/build/GHC/CmmToAsm/AArch64/CodeGen.dyn_o )

compiler/GHC/CmmToAsm/AArch64/CodeGen.hs:176:15: error:
    parse error on input ‘{- | debugIsOn -}’
    |
176 | ann doc instr {- | debugIsOn -} = ANN doc instr
    |               ^^^^^^^^^^^^^^^^^
cabal: Failed to build ghc-lib-9.2.3.20220527 (which is required by test:tests
from hls-hlint-plugin-1.0.4.0). See the build log above for details.
@shayne-fletcher
Copy link
Contributor

shayne-fletcher commented Jul 3, 2022

@kokobd the error message above indicates the error emanates from ghc-lib. why does hs-lint-plugin have a build dependence on ghc-lib? hlint only requires ghc-lib-parser.

@shayne-fletcher
Copy link
Contributor

reopened https://gitlab.haskell.org/ghc/ghc/-/issues/20920 and added a note

@kokobd
Copy link
Author

kokobd commented Jul 4, 2022

@shayne-fletcher

why does hs-lint-plugin have a build dependence on ghc-lib

Actually, the dependency is not necessary.
hls-hlint-plugin only uses some SrcSpan related functions, which can be imported from ghc-lib-parser instead.
image

I will fix that in HLS.

@shayne-fletcher
Copy link
Contributor

@shayne-fletcher

why does hs-lint-plugin have a build dependence on ghc-lib

Actually, the dependency is not necessary.
hls-hlint-plugin only uses some SrcSpan related functions, which can be imported from ghc-lib-parser instead.
image

I will fix that in HLS.

awesome. that's the right thing to do for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants