Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build folder #406

Closed
maruilian11 opened this issue Jun 9, 2016 · 7 comments
Closed

add build folder #406

maruilian11 opened this issue Jun 9, 2016 · 7 comments

Comments

@maruilian11
Copy link

maruilian11 commented Jun 9, 2016

hi, recently we want to add your lib to https://cdnjs.com, could you please consider adding a build folder with built files so that we can use git auto-update depending on git tags to grab each released version files for browser.
thank you very much!

cdnjs/cdnjs#6190

@dlongley
Copy link
Member

Hopefully will be addressed in a new release now that #456 has been merged.

@davidlehn
Copy link
Member

0.7.0 has been released which includes a built dist/forge.min.js file.

@davidlehn
Copy link
Member

@maruilian11
Copy link
Author

Many thanks!

@maruilian11
Copy link
Author

maruilian11 commented Feb 19, 2017

@davidlehn Is it ok to generate bundle and minified files for Bowser from npm package before v0.7.0 with npm install, npm run minify and npm run bundle? I mean is there any difference to use git repo forge-dist or npm package node-forge as source? Because we are afraid node-forge is for node use. Just want to confirm this. Thanks!

cdnjs/cdnjs#10572 (comment)

@davidlehn
Copy link
Member

Most of the pre 0.7.0 npm packages have everything thrown in them so can probably be used to build bundles. I don't know how far back that is true. All the cruft was stripped out in one recent release but the parts needed to build bundles were added back since apparently people used that.

For <0.7.0 the git source of forge-dist is the same as the main forge repo. For >=0.7.0 the forge-dist repo is just for built bundles and used to support bower and similar systems. The built files in the node-forge npm package are the same thing. They both are build with webpack using UMD format so should load in node or browser environments. Unfortunate choice of "node-forge" for the npm package since it can now be used in other ways, but a bit late to change that now.

It seems like only support for 0.7.0+ is needed going forward and that could just use the npm package. The bundles were added specifically to make unpkg and cdnjs easier to support.

@maruilian11
Copy link
Author

maruilian11 commented Feb 21, 2017

Thank you for your explanation 😃

For <0.7.0 the git source of forge-dist is the same as the main forge repo.

So for < 0.7.0, source in forge-dist repo is also the same as npm package, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants