Skip to content
This repository has been archived by the owner on Oct 20, 2020. It is now read-only.

Specify Python compatibility requirements #24

Closed
thundergolfer opened this issue Mar 9, 2020 · 3 comments
Closed

Specify Python compatibility requirements #24

thundergolfer opened this issue Mar 9, 2020 · 3 comments

Comments

@thundergolfer
Copy link
Collaborator

Description

Our code uses f-strings which are only available in >= Python 3.6. We should remove them or at least specify in the README that we don't support <= 3.5

@dillon-giacoppo
Copy link
Owner

dillon-giacoppo commented Mar 10, 2020

Python 3.5 is not EOL until September 13 2020 (https://devguide.python.org/#status-of-python-branches). I think it makes sense to support the oldest supported release of Python. I think the correct approach is to remove the f-strings.

I think its worth stating in the README that supported versions are 3.5+

@thundergolfer
Copy link
Collaborator Author

Agreed.

@dillon-giacoppo
Copy link
Owner

Fixed in 0.1.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants