Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should notify when git diff would prevent publish #12

Open
dillonkearns opened this issue Aug 26, 2021 · 0 comments
Open

Should notify when git diff would prevent publish #12

dillonkearns opened this issue Aug 26, 2021 · 0 comments

Comments

@dillonkearns
Copy link
Owner

elm publish will abort if there are any uncommitted changes, using this logic:

https://github.com/elm/compiler/blob/770071accf791e8171440709effe71e78a9ab37c/terminal/src/Publish.hs#L257-L264

elm-publish-action should be as close as possible to giving the elm publish feedback as a dry run when it is running without a new version to publish. The goal should be to have as much confidence as possible that the publish will succeed if and when you bump the version.

Auto stash option

As a bonus, it might be convenient to also provide a stash option. To be explicit, the default should be to give an error if there are uncommitted changes. But if you want to ignore them, there could be an option to automatically stash and unstash to run the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant